New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acos(-1) and add utils.extra_samples #16

Merged

pearu merged 2 commits into main from pearu/acos_extra

Jul 30, 2024

Owner

pearu commented Jul 30, 2024 •

edited

Loading

In this PR:

Fix acos algorithm for acos(-1) -> pi (was -> 0 which is incorrect), reported in Fix acos op decomposition for non complex numbers to be more accurate openxla/stablehlo#2452
Add utils.extra_samples to get special samples for the given function, fixes Add special values samples to acos #11
Fix utils.real_samples to return ULP-difference uniform samples

pearu added 2 commits

July 30, 2024 15:11


          Introduce utils.extra_samples. Use ULP-difference uniform samples.

fa38337


          Fix evaluation of acos(-1)

64cea92

pearu merged commit 7503d40 into main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet